Question

Why was the selling of weapons to iran in the iran-contra affair controversial?

Answer 1

The selling of weapons to Iran in the Ira-Contra affair was considered controversial because the senior administration officials of the Reagan Administration were secretly facilitating the sale of arms to Iran, which was the subject of an arms embargo during that time.

Answer 2

it contradicted the administrations policy of refusing to negotiate with terrorists

I hoped this help :D